#704 update landing page #748
Conversation
|
Performance is really low, might be due to having a bunch of PNG's on the page. Although, pretty sure Lighthouse is doing it's performance test on the development build of the site. Might be better in prod version of the build. Not sure if you want to consider lazy loading a landing page or fetching those images from a remote database. I heard MUI isn't great in terms of performance and that a headless UI could be a better and less bloated option but if we're on a time crunch it's probably best to put the idea on the backburner. |
There was a problem hiding this comment.
Sweet, thanks for the big chunk of work! I left some comments inline. I'll be sure to respond quicker this time.
I'm going to see if I can ask design for .svg files to reduce that initial load size because these images do indeed have a big hit on performance.
| "@emotion/react": "^11.10.5", | ||
| "@emotion/styled": "^11.10.5", | ||
| "@material-ui/core": "^4.11.2", | ||
| "@material-ui/icons": "^4.11.2", | ||
| "@mui/icons-material": "^5.10.9", | ||
| "@mui/material": "^5.10.13", |
There was a problem hiding this comment.
Which of these new packages are necessary? Let's try to stay contained within our used third-party libraries unless needed. We can find alternate icons or work with design if we're missing some.
We also aren't using styled-components, and you can just use plain css for now if needed, so let's remove them.
There was a problem hiding this comment.
icons-material is for the arrow in the accordion, don't necessarily need it.
The rest are needed to generate the MUI accordion itself.
Are you suggesting just building the accordion from scratch?
There was a problem hiding this comment.
Also found this info which I thought was interesting.. Don't usually work with MUI so it was nice to learn
https://mui.com/material-ui/guides/minimizing-bundle-size/
There was a problem hiding this comment.
icons-material is for the arrow in the accordion, don't necessarily need it. The rest are needed to generate the MUI accordion itself. Are you suggesting just building the accordion from scratch?
What I mean is we already have material-ui v4 which has an accordion component and the arrows if you look for ExpandMore and ExpandLess. No need to bring in another package with v5
There was a problem hiding this comment.
I see. I'll stick to v4. BTW both links go to the same url, could you update the url for accordion, please?
|
Closing to rebuild this. |
Addresses issue #704
Preview screenshots
Before changes
After changes
