Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1194 Update MaterialUI icons #1653

Merged
merged 17 commits into from
Jan 6, 2025
Merged

1194 Update MaterialUI icons #1653

merged 17 commits into from
Jan 6, 2025

Conversation

eburdekin
Copy link
Member

@eburdekin eburdekin commented Nov 19, 2024 •
edited
Loading

Fixes #1194

Changes Made

  • Update MaterialUI icons across app to use rounded style
  • Refactor Credits page to use icon imports vs svg files, alphabetize, add missing icons, and resolve eslint/React warnings

Reason for Changes

  • Design audit that determined we had inconsistent icon styling across the app

Action Items

  • change base branch to dev
  • review PR files to guarantee ONLY relevant code is present
  • add ready for dev lead task ready for dev lead to evaluate label

@eburdekin
replace arrow icons in button component
0ff9d45
@eburdekin
replace expandmore icons in landing page, faq components
0f7933b
@eburdekin
replace menu & close buttons in appheader component
18118ca
@eburdekin
update pencil icon in textpreview component
01da24d
@eburdekin
change CreditsObject props to camel case
714172e
@eburdekin
add key prop to resolve warning (Each child in a list should have a u…
3f1c7d8 
…nique key prop.)
@eburdekin
refactor credits page to use icon imports instead of saving svgs
7e8e115
@eburdekin
update email icon on download & credits pages
f27611e
@eburdekin
update more svgs to icon imports on credits page
ee99c0f
@eburdekin
update erroralert icon on before you begin page & credits page
1033723
@eburdekin
update help icon in popup component & credits page
6febfd6
@eburdekin
remove duplicate svg files, move group-chat image to main assets folder
4f370ad
@eburdekin
update cancel icon on advice page, credits page
0bd5532
@eburdekin
update check circle icons & refactor advice page
f422471
@eburdekin
update eye icons, alphabetize credits page
f472e31
@eburdekin
update icons on download page
f338884
@eburdekin
fix typo, add material as artist for new icons
605b609
@eburdekin eburdekin added the ready for dev lead task ready for dev lead to evaluate label Nov 19, 2024
sydneywalcoff
sydneywalcoff approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eburdekin !!!
This is beautiful! Thank you for removing the duplicated svgs in the credits that were covered by material UI icons!

@sydneywalcoff sydneywalcoff merged commit 8a08be0 into dev Jan 6, 2025
1 check passed
@eburdekin eburdekin deleted the 1194-update-icons branch January 7, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydneywalcoff sydneywalcoff sydneywalcoff approved these changes

Assignees
No one assigned
Labels
ready for dev lead task ready for dev lead to evaluate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eburdekin @sydneywalcoff