Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Update Icons #1194

Closed
3 tasks done
Tracked by #1200
jyehllow opened this issue Mar 7, 2024 · 5 comments · Fixed by #1661
Closed
3 tasks done
Tracked by #1200

Code Update Icons #1194

jyehllow opened this issue Mar 7, 2024 · 5 comments · Fixed by #1661
Assignees
@eburdekin
Labels
feature: Style Guide guidance on writing and visual components front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: low role: development anything related to code size: 1pt can be done in 6 hours or less
Milestone
07. Existing Feat...

Comments

@jyehllow
Copy link
Member

jyehllow commented Mar 7, 2024 •
edited by eburdekin
Loading

Dependency

Overview

From the credits page, we noticed that some of our icons aren't consistent in styling
Dev will need to replace outdated icons with the new ones

Action Items

  • replace icons using the updated icons in comment below.
  • update credits page to reflect changes

Resources/Notes
@jyehllow jyehllow added role: development anything related to code priority: low dependency The issue or reason why this issue is in the icebox size: 1pt can be done in 6 hours or less feature: Style Guide guidance on writing and visual components labels Mar 7, 2024
@jyehllow jyehllow mentioned this issue Mar 7, 2024
Closed
14 tasks
@jyehllow jyehllow added this to the Launch Prep milestone Mar 7, 2024
@anitadesigns anitadesigns added ready for dev lead task ready for dev lead to evaluate issue level I: request Smallest type of issue; Typically can be completed by one person front-end type of development task relating to the website labels Mar 7, 2024
@sydneywalcoff sydneywalcoff mentioned this issue Mar 7, 2024
Open
4 tasks
@sydneywalcoff sydneywalcoff changed the title Replace/implement new icons Code Update Icons Mar 7, 2024
@sydneywalcoff sydneywalcoff removed their assignment Mar 7, 2024
@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label Mar 8, 2024
@eruan8888
Copy link
Member

The link to the figma section where I replace all the old icons with new ones can be found here. https://www.figma.com/design/hYqRxmBVtJbDv9DJXV6nra/Expunge-Assist-Main-Figma?node-id=16808-29252&t=eNVfG1wARFUuEO8M-4

@eruan8888
Copy link
Member

info
mdi_round_eye icon
mdi_rounded_alert
mdi_rounded_arrow-right
mdi_rounded_check-box-checked
mdi_rounded_check-box-unchecked
mdi_rounded_check-circle-24x24
mdi_rounded_check-circle-48x48
mdi_rounded_close-circle-48x48
mdi_rounded_copy
mdi_rounded_down
mdi_rounded_download
mdi_rounded_edit
mdi_rounded_email
mdi_rounded_hamburger
mdi_rounded_radio-button-outline blank
mdi_rounded_radio-button-outline checked
mdi_rounded_right
msi_rounded_Microsoft Word

@eruan8888 eruan8888 added ready for dev lead task ready for dev lead to evaluate and removed dependency The issue or reason why this issue is in the icebox feature: Style Guide guidance on writing and visual components labels Oct 20, 2024
@eruan8888 eruan8888 moved this from Icebox to New Issues for approval in P: EA: Project Board Oct 20, 2024
@sydneywalcoff sydneywalcoff added feature: Style Guide guidance on writing and visual components and removed ready for dev lead task ready for dev lead to evaluate labels Oct 25, 2024
@sydneywalcoff sydneywalcoff mentioned this issue Nov 5, 2024
Open
@eburdekin eburdekin self-assigned this Nov 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Hey @eburdekin! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

@eburdekin eburdekin moved this from Prioritized Backlog to In Progress (active) in P: EA: Project Board Nov 6, 2024
@eburdekin

This comment was marked as outdated.

Sign in to view
@eburdekin
Copy link
Member

eburdekin commented Nov 19, 2024 •
edited
Loading

@sydneywalcoff realized I can't find the following icons because they don't exist in Material 4 😅 since it's a much bigger project to update to Material 5 (or 6), I'd propose we use these for the time being.

Icon from wireframe Icon from Material 4 library
mdi_rounded_copy msi_rounded_Microsoft Word ContentCopyRounded
mdi_rounded_download GetAppRounded
mdi_rounded_edit EditRounded

@eburdekin eburdekin mentioned this issue Nov 19, 2024
Merged
3 tasks
@eburdekin eburdekin moved this from In Progress (active) to Ready for Review in P: EA: Project Board Nov 19, 2024
@rcpeng34 rcpeng34 mentioned this issue Nov 22, 2024
Open
1 task
@sydneywalcoff sydneywalcoff mentioned this issue Jan 6, 2025
Merged
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in P: EA: Project Board Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eburdekin eburdekin

Labels
feature: Style Guide guidance on writing and visual components front-end type of development task relating to the website issue level I: request Smallest type of issue; Typically can be completed by one person priority: low role: development anything related to code size: 1pt can be done in 6 hours or less
Projects
P: EA: Project Board
Status: Done
Milestone
07. Existing Feature Improvements
Development

Successfully merging a pull request may close this issue.

Dev hackforla/expunge-assist
6 participants
@rcpeng34 @jyehllow @sydneywalcoff @eruan8888 @anitadesigns @eburdekin