-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BrowserRouter, referral tracking, Mixpanel #649
Merged
adamkendis
merged 15 commits into
hackforla:dev
from
adamkendis:609-FRONT-311DataMixpanel
May 26, 2020
Merged
BrowserRouter, referral tracking, Mixpanel #649
adamkendis
merged 15 commits into
hackforla:dev
from
adamkendis:609-FRONT-311DataMixpanel
May 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmensch1
approved these changes
May 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all looks real solid. I like the switch between the two environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #609
Closes #611
Closes #626
BrowserRouter
#
from the url. Pretty sure this won't break any front end routing but will need to check when we push the latest dev build to S3.Referral link tracking
RouteChange
component. This component renders nothing but calls a list of actions passed via props whenever the pathname changes. Actions are defined and registered in routeChangeActions.js. Anything we want to check for/fire off when the route changes can be added here.handleReferralCode
route change action looks for thereferral
query parameter in the url. Ifreferral
exists, it fires a Mixpanel event with the referral code and current path as properties. The current pathname is pushed into the router history for a clean url.Mixpanel
Copy to your .env file.
-1
to disable Mixpanel,1
to enable. If enabled, it'll swap between dev/prod tokens based onNODE_ENV
so we're not polluting production data.Events:
About 311 - triggered when user navigates to /about
dev
branchAny questions? See the getting started guide