Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRONT - Routing changes, CloudFront, Route53 options #626

Closed
4 tasks done
adamkendis opened this issue May 19, 2020 · 0 comments · Fixed by #649
Closed
4 tasks done

FRONT - Routing changes, CloudFront, Route53 options #626

adamkendis opened this issue May 19, 2020 · 0 comments · Fixed by #649
Assignees
@adamkendis
Labels
Role: DevOps infrastructure, CI or related work Role: Frontend React front end work v1 The first version of the site
Milestone
311-Data - Beta

Comments

@adamkendis
Copy link
Member

adamkendis commented May 19, 2020 •
edited
Loading

Description

React-router's HashRouter was used to circumvent some gh-pages routing issues. Now that the frontend has been migrated to S3/CloudFront distribution, we have more fine-tuned control over routing and error redirects. The goal is to remove the # from the url so users can navigate straight to the About/Contact pages or refresh the browser on those pages without getting a 403 or 404 error.

Action Items

  • Swap in BrowserRouter for HashRouter.
  • CloudFront - Redirect HTTP to HTTPS.
  • CloudFront - Create custom error responses. On 403/404, respond with /index.html and 200.
  • Route53 - Get www working with domain.

Resources
@adamkendis adamkendis added Role: Frontend React front end work Role: DevOps infrastructure, CI or related work labels May 19, 2020
@adamkendis adamkendis added this to the 311-Data - Beta milestone May 19, 2020
@adamkendis adamkendis self-assigned this May 19, 2020
@adamkendis adamkendis mentioned this issue May 26, 2020
Merged
4 tasks
@Rabia2219 Rabia2219 added the v1 The first version of the site label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamkendis adamkendis

Labels
Role: DevOps infrastructure, CI or related work Role: Frontend React front end work v1 The first version of the site
Projects
P: 311: Project Board
Status: Done
Milestone
311-Data - Beta
Development

Successfully merging a pull request may close this issue.

BrowserRouter, referral tracking, Mixpanel adamkendis/311-data
2 participants
@adamkendis @Rabia2219