icon components #234
Merged
icon components #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Fixes #226 |
brodly
reviewed
Feb 9, 2020
src/components/common/Icons.js
Outdated
| color: PropTypes.string, | ||
| size: PropTypes.oneOf(['small', 'medium', 'large']), | ||
| iconTag:PropTypes.string, | ||
| iconSize:PropTypes.string, |
There was a problem hiding this comment.
Do you think we can add a PropTypes.oneOf here similar to how you did the size proptype, but with the FontAwesome size variations?
There was a problem hiding this comment.
Added propTypes options for iconSize.
brodly
reviewed
Feb 9, 2020
src/components/common/Icons.js
Outdated
| handleClick: PropTypes.func, | ||
| color: PropTypes.string, | ||
| size: PropTypes.oneOf(['small', 'medium', 'large']), | ||
| iconTag:PropTypes.string, |
There was a problem hiding this comment.
Can we change the word iconTag to icon?
brodly
reviewed
Feb 9, 2020
src/components/common/Icons.js
Outdated
| [`is-${size}`]: size, //for small, meduim, large, span tag | ||
| [`has-text-${color}`]: color, | ||
| [`fas-fa${iconSize}`]:iconSize //for fa-lg, fa-2x, fa-3x, icon tag | ||
| }); |
There was a problem hiding this comment.
add icon to the classNames function so we can just add the name of the icon without the fa-
brodly
suggested changes
Feb 9, 2020
Closed
brodly
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icon components have been created and ready for review