Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Icon Component #226

Closed
brodly opened this issue Feb 1, 2020 · 7 comments · Fixed by #234
Closed

Create Icon Component #226

brodly opened this issue Feb 1, 2020 · 7 comments · Fixed by #234
Assignees
Labels
Role: Frontend React front end work v1 The first version of the site

Comments

@brodly
Copy link
Member

brodly commented Feb 1, 2020

Overview

As a developer, I want to be able to load Icons into the application by importing a React Icon Component where it is needed, pass in my preferred props, and have the icon render.

Action Items

  1. Import Font Awesome library into application (CDN/or otherwise)
  2. Research Bulma Icon style guide
  3. Create Icon component in the /src/common/ folder of application
  4. Allow for full customizing of icon via props per Bulma

Notes:
Icons should handle both click and mouseover events

Resources/Instructions

Bulma Style Guide:
https://bulma.io/documentation/elements/icon/

Font Awesome:
https://fontawesome.com/

@brodly brodly added the Role: Frontend React front end work label Feb 1, 2020
@ExperimentsInHonesty
Copy link
Member

@ainneo says re eta, might have something to show josh on Tuesday 2/4.

@johnr54321
Copy link
Member

New ETA is now 2/11. If not complete, will look at other options for completion then.

@ainneo
Copy link
Member

ainneo commented Feb 5, 2020

@johnr54321 @ExperimentsInHonesty @brodly @adamkendis Hi All! Icon component is complete... However it seems I do not have rights to push to this branch. I did clone the dev branch successfully... error message:

On branch dev
remote: Resolving deltas: 100% (5/5), completed with 5 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/dev.
remote: error: 5 of 5 required status checks are expected. At least 1 approving review is required by reviewers with write access.
To https://github.com/hackforla/311-data.git
 ! [remote rejected] dev -> dev (protected branch hook declined)
error: failed to push some refs to 'https://github.com/hackforla/311-data.git'

Please fix my permissions. Thanks!

@adamkendis
Copy link
Member

@ainneo
dev has protections preventing pushes directly to the branch. Our code changes are merged into dev via pull request. See:

https://github.com/hackforla/311-data/blob/master/GETTING_STARTED.md
https://www.atlassian.com/git/tutorials/comparing-workflows/feature-branch-workflow

Feel free to ping me if you have questions!

@ainneo
Copy link
Member

ainneo commented Feb 7, 2020

Thanks @adamkendis for the info! Team, the icon component has been pushed to branch icons and a PR request has been submitted and ready for review @sellnat77
link: #234
Thanks! Ainne

@johnr54321
Copy link
Member

@ainneo We understand that you may need to take a little time off. We look forward to seeing you back, but will take this ticket in the mean time. @adamkendis will finish this based on comments from pull request. ETA: 2/18.

@adamkendis adamkendis linked a pull request Feb 14, 2020 that will close this issue
@adamkendis
Copy link
Member

Merged #234

@Rabia2219 Rabia2219 added the v1 The first version of the site label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Role: Frontend React front end work v1 The first version of the site
Projects
Development

Successfully merging a pull request may close this issue.

6 participants