Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1401 fe update color of reports dropdown #1404

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

jekijo
Copy link
Member

@jekijo jekijo commented Oct 13, 2022

Fixes #{1401}

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@jekijo jekijo requested a review from nichhk October 13, 2022 19:54
@jekijo jekijo self-assigned this Oct 13, 2022
@edwinjue
Copy link
Member

edwinjue commented Oct 17, 2022

hi @jekijo, for some reason the Header.jsx does not look like the latest one. Would you mind pulling the most recent version by executing the following into your branch:

git checkout dev
git pull
git checkout 1401-fe-update-color-of-reports-dropdown
git merge dev

Thanks

image

@edwinjue
Copy link
Member

edwinjue commented Oct 17, 2022

Hi @jekijo, hope you don't mind. I went ahead and updated the branch to the latest.

I also replaced hardcoded color values with constants defined in '@theme/colors'.

We should be good now. Please let me know if you have any questions.

image

@edwinjue
Copy link
Member

edwinjue commented Oct 17, 2022

Also, not sure if you use VSCode but the color-highlight plugin is pretty useful

image

It allows me to see @theme/colors like this:
image

https://ourcodeworld.com/articles/read/887/how-to-highlight-colors-rgb-hex-hsl-rgba-in-visual-studio-code

@jekijo
Copy link
Member Author

jekijo commented Oct 17, 2022

@edwinjue Awesome! Thank you! I'll definitely check out the color-highlight plugin

@jekijo jekijo requested a review from edwinjue October 17, 2022 21:11
@jekijo jekijo merged commit c389c20 into dev Oct 17, 2022
@jekijo jekijo deleted the 1401-fe-update-color-of-reports-dropdown branch October 17, 2022 21:22
@edwinjue edwinjue linked an issue Oct 17, 2022 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Color of Reports Dropdown And The Page Selection Underline.
2 participants