Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Color of Reports Dropdown And The Page Selection Underline. #1401

Closed
2 tasks done
melissahermes99 opened this issue Oct 13, 2022 · 7 comments · Fixed by #1404 or #1474
Closed
2 tasks done

Update Color of Reports Dropdown And The Page Selection Underline. #1401

melissahermes99 opened this issue Oct 13, 2022 · 7 comments · Fixed by #1404 or #1474
Assignees
Labels

Comments

@melissahermes99
Copy link
Member

melissahermes99 commented Oct 13, 2022

Overview

We need to change the background color on the reports menu dropdown to #0F181F and change the yellow underline #FFB100. Currently, the dropdown is #FFFFFF and the underline is #FFFF00. These need to be updated.

Action Items

  • Update background color of the reports menu dropdown to #29404F
  • Update the yellow underlines for page selection to #FFB100

Resources/Instructions

image
image

@nichhk nichhk added the Size: 1pt Can be done in 6 hours label Oct 13, 2022
@edwinjue edwinjue linked a pull request Oct 17, 2022 that will close this issue
4 tasks
@edwinjue
Copy link
Member

@melissahermes99 marking this as closed because the requested changes have been merged to dev. Please take a look and let me know if this is what was expected. If you require any further customizations, please do so as a new issue. Thanks!

@nichhk
Copy link
Member

nichhk commented Oct 25, 2022

reports-dd-bg

I'm finding that there's not enough contrast between the text and the background. @melissahermes99 , do you have any suggestions? Thanks!

@melissahermes99
Copy link
Member Author

melissahermes99 commented Oct 26, 2022

Could we make the text and underlines #FFFFFF to look something like this?
image

@edwinjue
Copy link
Member

edwinjue commented Nov 4, 2022

Hi @melissahermes99, thought I'd let you know I went ahead and implemented this locally just now.

You can expect to see the change along with rest of the v2 Desktop Filter updates once they get approved

image

@edwinjue
Copy link
Member

edwinjue commented Nov 4, 2022

@melissahermes99 Perhaps, I should ask whether you would like the underline to always appear or only when the link is highlighted like this:

image

Please let me know thanks!

@melissahermes99
Copy link
Member Author

melissahermes99 commented Feb 15, 2023

rhaps, I should ask whether you would like the underline to always appear or only when the link is highlighted like this:

Sorry for the late reply, I was going through my missed notifications! Yes, we would like the underlines to only appear when an item is being hovered over. Also, would it be possible to remove the purple underline?

In addition, there seems to be a slight mix-up on my part. We need to change hover to yellow underline #FFB100

The original issue is located here #1147 (comment)

@melissahermes99
Copy link
Member Author

melissahermes99 commented Feb 23, 2023

@funbunch Update as of 2/22/23 Color of drop downs should now be #29404F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (without merge)
5 participants