Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1283 date range selector should display the date range for the past week by default #1296

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented Jul 26, 2022

Fixes #1283

The DatePicker was not showing the default date range of the past week since it was relying on local state to render the date range, instead of relying on the date range in the Redux store. This PR gets rid of local date state in most of our date-related components, and makes the DatePicker use the dates from the Redux store.

Now we can see that the default of 1 week is shown in the date range when the user opens the app:
default-date-range

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk requested review from funbunch and ardada2468 July 26, 2022 17:43
@nichhk nichhk linked an issue Jul 26, 2022 that may be closed by this pull request
1 task
@nichhk
Copy link
Member Author

nichhk commented Jul 27, 2022

Thanks Shannan!

@nichhk nichhk merged commit bd7a2f5 into dev Jul 27, 2022
@nichhk nichhk deleted the 1283-date-range-selector-should-display-the-date-range-for-the-past-week-by-default branch July 27, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date range selector should display the date range for the past week by default
2 participants