Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date range selector should display the date range for the past week by default #1283

Closed
1 task
nichhk opened this issue Jul 14, 2022 · 1 comment · Fixed by #1296
Closed
1 task

Date range selector should display the date range for the past week by default #1283

nichhk opened this issue Jul 14, 2022 · 1 comment · Fixed by #1296
Assignees
Labels
P-feature: Map Role: Frontend React front end work Size: 5pt Can be done in 19-30 hours

Comments

@nichhk
Copy link
Member

nichhk commented Jul 14, 2022

Overview

In PR #1268 , we changed the dev site to get data from the past week by default. However, this is not reflected in the DateSelector--it just says "Select a date range". This should be updated.

Action Items

  • I'm not quite sure where this change is supposed to go right now, but it would be somewhere in here or one of the React components that it uses. We can search for "Select a date range" in our repository and see which component is using that string as a default value.
@nichhk nichhk added Role: Frontend React front end work Size: 2pt Can be done in 7-12 hours P-feature: Map labels Jul 19, 2022
@nichhk nichhk added this to the v2.1 Launch milestone Jul 19, 2022
@nichhk nichhk self-assigned this Jul 20, 2022
@nichhk nichhk added Size: 5pt Can be done in 19-30 hours and removed Size: 2pt Can be done in 7-12 hours labels Jul 26, 2022
@nichhk
Copy link
Member Author

nichhk commented Jul 26, 2022

This task ended up being more complicated because many of our date-related components were using local React state instead of the Redux store. So I had to go through these components and remove the local date state, while replacing it with the Redux dates where appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-feature: Map Role: Frontend React front end work Size: 5pt Can be done in 19-30 hours
Projects
Status: Done (without merge)
1 participant