Upgrade dashboard interaction issue #1249
Conversation
|
There seems to be some issues with automatic checks on alembic. I am not entirely sure why. Could this be something to do with database recreation in order to fix the v1 site (Issue #1239 ? ) |
|
Hey I just reran the test, and it passed successfully. I guess the database wasn't initialized properly in your run. The test brings up a local database, so we wouldn't expect any issues with the prod database to affect it. I'll start reviewing these changes now, thanks! |
There was a problem hiding this comment.
Thanks for figuring this out Josh!
I mentioned this in the comments, but Piero is actively working on updating neighborhoods.py in PR #1242. Let's wait for him to merge that before applying the Dash upgrade to that file.
In general, my comments are about Python style. In particular, we should use snake_case for variable names. We should also organize imports as described here: https://google.github.io/styleguide/pyguide.html#313-imports-formatting.
server/dash/app.py
Outdated
|
|
||
| external_stylesheets = ['/static/reports.css'] | ||
| app = dash.Dash(__name__, external_stylesheets=external_stylesheets) | ||
| server = flask.Flask(__name__) # define flask app.server |
There was a problem hiding this comment.
The comment here is not informative beyond the code itself, so we can get rid of it.
| import textwrap | ||
|
|
||
| import dash_core_components as dcc | ||
| import dash_html_components as html | ||
| import pandas as pd |
There was a problem hiding this comment.
Ditto, please follow guidelines for import formatting here: https://google.github.io/styleguide/pyguide.html#313-imports-formatting
| import textwrap | ||
|
|
||
| import dash_core_components as dcc | ||
| import dash_html_components as html | ||
| import pandas as pd |
There was a problem hiding this comment.
Ah, I just remembered that Piero is updating this file right now. Let's wait until he merges his PR, and then could you pull and update the dash stuff please?
server/dash/index.py
Outdated
| from dash.dependencies import Input | ||
| from dash.dependencies import Output | ||
| from dash import Dash, html, dcc, callback, Input, Output | ||
| # from dash.dependencies import Input, Output |
| BATCH_SIZE = 10000 | ||
|
|
||
| def batch_get_data(url): | ||
| # set up your query |
There was a problem hiding this comment.
Please capitalize the start of all comments, and add a period at the end.
|
Could you use an autoformatter for Python in your code editor? I think that will help with some of the style issues like spacing. |
Fixes #1246
Any questions? See the getting started guide