Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotly Dash Versioning Issue #1246

Closed
2 of 4 tasks
joshuayhwu opened this issue Jun 13, 2022 · 3 comments
Closed
2 of 4 tasks

Plotly Dash Versioning Issue #1246

joshuayhwu opened this issue Jun 13, 2022 · 3 comments

Comments

@joshuayhwu
Copy link
Contributor

joshuayhwu commented Jun 13, 2022

Overview

Existing plotly dashboards versions are from v1.x while the current plotly dash is on v2.x. There is no longerr any documentation available for older versions of Dash and an upgrade is necessary.

Currently, I have succesfully upgrade the code and tested in a separate directory with new dashboard incorporated in there. However, then repeating the process in 311 Code base, none of the callback functions get triggered (i.e. no interactivity possible), while the static visuals still get render. I suspect this is something to do with gunicorn interfering with the callbacks being fire, as everything works perfectly without gunicorn. One thing worth mentioning is that this sometimes occur prior to upgrade as well, but the issue will resolve after reloading a few times.

Action Items

  • Determine which existing dashboards we want to keep
  • Upgrade desired dashboards to newest version to work with docker
  • Ensure new vesrions of dashboards are compatible with gunicorn
  • Integrate new dashboards with existing code base

Resources/Instructions

@nichhk
Copy link
Member

nichhk commented Jun 14, 2022

In the next team meeting, can you and the team try to figure out which of the existing dashboards we want to maintain, and which we can get rid of? Independent of that, I think we can merge the "long" and "recent" versions of each dashboard into a single dashboard.

Then, we can start to perform the upgrade.

@joshuayhwu
Copy link
Contributor Author

joshuayhwu commented Jun 15, 2022

Sounds good. We will get a vote on those and see which ones we could combine.

EDIT: apologies Nich, we didn't have time to discuss the combining dashboard issue after gathering feedback for the current prototype. I agree with your suggestion of combining: combining neighborhood_recent with neighborhood, deprecating overview and recent after incorporating some visuals to currrent prototype, and leave the types_map dashboard with something Piero could work on. Let me know how that sound.

@joshuayhwu
Copy link
Contributor Author

Fixed with #1249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants