Fixed updates affecting only root + updating ship without going through matchups #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BudzioT
requested review from
malted,
maxwofford and
polytroper
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BudzioT
changed the title
|
Fixed the ability to ship an update without going through initial matchups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically earlier we updated only the root ship, but matchups take the latest entry. That means that any edit done (title, deployment, readme) on a ship that was updated wouldn't work!
I changed it to update the latest entry, which looks like it's working in Airtable, meaning people should be able to actually edit their ships info now.
Updates are complex though, so please test it throughly, I've only done one edit -> check info, one update -> check info, which looked like it worked.