Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect links for updates + allowing updates on ships before going through 10 matchups #975

Closed
BudzioT opened this issue Dec 15, 2024 · 4 comments · Fixed by #981
Closed
Assignees

Comments

@BudzioT
Copy link
Collaborator

BudzioT commented Dec 15, 2024

Incorrect links for updates
Some people have been reporting this, but now it just blessed me, with why it can be true.
Are we taking deploy/screenshot link from root? Or updating only root ship and taking demo from the newer iteration when editing a ship? Cause people get old demos/screenshots for updates

Wrong updates
It seems like if ship has at least one update, people can ship an update before ship goes through 10 matchups, making the update before stuck forever without payout (as reshipped_to is set and it doesn't appear in matchups)

@BudzioT
Copy link
Collaborator Author

BudzioT commented Dec 15, 2024

I think this is sort of @malted mission

@polytroper
Copy link
Collaborator

Assigning to @malted but @BudzioT if you are feeling hungry feel free to unassign him and wolf this down yourself

@BudzioT
Copy link
Collaborator Author

BudzioT commented Dec 18, 2024

I can try, one part is basically already done in my PR and I think I know why people can update ships when they shouldn't. Will try to fix today

@BudzioT
Copy link
Collaborator Author

BudzioT commented Dec 18, 2024

This should fix it, works on basic tests, but feel free to test it more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants