v7.0 Docs Update #2074
Merged
v7.0 Docs Update #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unneeded x-ua-compatible - not needed for IE11 - Update many external links - Fix typos - Add info for creating a good meta description - Add link for iPhone X viewport info - Update browser upgrade prompt - Remove integrating Bootstrap with H5BP (it was written a longtime ago and I don't think is relevant so much) - Remove statement that Twitter Cards requires registering a domain - Remove official shortlink section, it was always very poorly supported - Made the touch icons sections more consise (no need at all to mention about non-retina iPhones and iOS versions prior to iOS 6 etc)
- update package,json deps
This was referenced Oct 8, 2018
Closed
|
Hey, you need any help? Want to get some open source experience, pretty new here. |
roblarsen
approved these changes
Feb 6, 2019
| @@ -620,19 +586,14 @@ Icons](https://mathiasbynens.be/notes/touch-icons). | |||
|
|
|||
| Apart from that it is possible to add start-up screens for web apps on iOS. This | |||
| basically works by defining `apple-touch-startup-image` with an according link | |||
| to the image. Since iOS devices have different screen resolutions it is | |||
| to the image. Since iOS devices have different screen resolutions it maybe | |||
| @@ -620,19 +586,14 @@ Icons](https://mathiasbynens.be/notes/touch-icons). | |||
|
|
|||
| Apart from that it is possible to add start-up screens for web apps on iOS. This | |||
| basically works by defining `apple-touch-startup-image` with an according link | |||
| to the image. Since iOS devices have different screen resolutions it is | |||
| to the image. Since iOS devices have different screen resolutions it maybe | |||
There was a problem hiding this comment.
where we actually need to make the change
|
going once... going twice... 🔨 |
|
Just wanted to point out that there is still a link/reference to integrating Bootstrap with H5BP in the FAQ, but there is no such content. Consider either re-adding the content or removing the link: (Btw., actually I was looking for exactly that content...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<meta name="theme-color" content="#fafafa">toindex.htmlsecurity.txtin extend docsTypes of changes
Checklist:
Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.
Thanks!