feat: support for Apple M1 silicon #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test appears to be failing because bcftools 1.19 and art 2016.06.05 don't have macOS ARM support But bcftools got it in 1.20 (see bioconda/bioconda-recipes#49104), so we just need to figure out ART Update: I'm now working on ART in aryarm/aryarm-conda#10 and bioconda/bioconda-recipes#50270 |
and hopefully use the latest art build which should support osx-arm64
aryarm
changed the title
aryarm
changed the title
|
The tests passed! @nicholema , can you try to install TRTools on your mac again? If it works, can you approve this PR? |
|
Thank you for adding this feature! It worked as,
conda env create -n trtools-conda -c conda-forge -c bioconda
'bioconda::trtools'
…On Thu, Aug 22, 2024 at 9:09 PM Arya Massarat ***@***.***> wrote:
@nicholema <https://github.com/nicholema> , can you try to install
TRTools on your mac again?
conda env create -n trtools-conda -c conda-forge -c bioconda 'bioconda::trtools'
—
Reply to this email directly, view it on GitHub
<#227 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANJ5YJT3DL5JV624BSK7UETZS2YVZAVCNFSM6AAAAABM6FG6F6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGE2DQMZVGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
nicholema
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cyvcf2 and pgenlib added support for m1 apple silicon. See bioconda/bioconda-recipes#50219 and bioconda/bioconda-recipes#50220. So can TRTools be run on macOS ARM now? Are there any other dependencies that fail with the newest macs?
Let's add a test to our CI for this. If it works, then we can add osx-arm64 to the "additional platforms" that are supported in our bioconda recipe