Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt to pass X.509 credentials to jobs #166

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Don't attempt to pass X.509 credentials to jobs #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions omicron/cli/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,10 +999,12 @@
dag.set_dag_file(str(dagpath.with_suffix("")))

# set up condor commands for all jobs
condorcmds = {'accounting_group': args.condor_accounting_group,
'accounting_group_user': args.condor_accounting_group_user,
'request_disk': args.condor_request_disk,
'use_x509userproxy': 'True'}
condorcmds = {

Check warning on line 1002 in omicron/cli/process.py

View check run for this annotation

Codecov / codecov/patch

omicron/cli/process.py#L1002 

Added line #L1002 was not covered by tests
"accounting_group": args.condor_accounting_group,
"accounting_group_user": args.condor_accounting_group_user,
"request_disk": args.condor_request_disk,
"request_memory": 1024, # MB
}
for cmd_ in args.condor_command:
key, value = cmd_.split('=', 1)
condorcmds[key.rstrip().lower()] = value.strip()
Expand All @@ -1013,8 +1015,9 @@
args.executable,
subdir=condir,
logdir=logdir,
**condorcmds
**condorcmds,
)

# This allows us to start with a memory request that works maybe 80%, but bumps it if we go over
# we also limit individual jobs to a max runtime to cause them to be vacates to deal with NFS hanging
reqmem = condorcmds.pop('request_memory', 1024)
Expand Down
Loading