Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to pass X.509 credentials to jobs #166

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

duncanmmacleod
Copy link
Member

This PR removes the use_x509userproxy command from all HTCondor workflows, none of the jobs need it.

This also sets a global default request_memory for all jobs to 1024, which isn't actually a change, but refactors slightly where the default is set.

@duncanmmacleod duncanmmacleod added this to the pyomicron 2.0.6 milestone Sep 1, 2023
@duncanmmacleod duncanmmacleod added pr:bug-fix Changes fix a bug, or a change unrelated to the public API script:omicron-process Related to the omicron-process script labels Sep 1, 2023
it is not needed at all, but do pass request_memory
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #166 (5030841) into master (02eb897) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   35.16%   35.16%           
=======================================
  Files          30       30           
  Lines        2944     2944           
=======================================
  Hits         1035     1035           
  Misses       1909     1909           
Flag Coverage Δ
Conda 35.16% <0.00%> (ø)
Linux 35.16% <0.00%> (ø)
macOS ?
python3.10 35.16% <0.00%> (ø)
python3.11 35.16% <0.00%> (ø)
python3.9 35.17% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
omicron/cli/process.py 11.82% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@duncanmmacleod duncanmmacleod removed this from the pyomicron 2.0.6 milestone Sep 19, 2023
Copy link
Collaborator

@areeda areeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@areeda areeda merged commit 62e4c52 into gwpy:master Oct 24, 2023
8 of 9 checks passed
@duncanmmacleod duncanmmacleod deleted the no-x509 branch October 27, 2023 12:42
@duncanmmacleod duncanmmacleod added this to the pyomicron 2.0.7 milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bug-fix Changes fix a bug, or a change unrelated to the public API script:omicron-process Related to the omicron-process script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants