Agent: Change the Agent to use the modified exploiter config

[VakarisZ]

What does this PR do?

Addresses #2785 (changes agent to be compatible with configuration changes)

Improved naming a bit

PR Checklist

• Have you added an explanation of what your changes do and why you'd like to include them?
• Is the TravisCI build passing?
• Was the CHANGELOG.md updated to reflect the changes?
• Was the documentation framework updated to reflect the changes?
• Have you checked that you haven't introduced any duplicate code?

Testing Checklist

• Added relevant unit tests?
• Have you successfully tested your changes locally? Elaborate:

  Tested by exploiting hadoop, looking at the logs

• If applicable, add screenshots or log transcripts of the feature working

[VakarisZ]

I'm not 100% sure about changing the sequence to Dict, but I think dict is more flexible and it's the responsibility of this method to determine the order based on configuration

[mssalvatore]

A Dict will preserve order. In this case, I think we should type hint with Dict instead of Mapping, as Mappings may not preserve order. Better yet, we should, perhaps, used OrderedDict to signal that order matters.

[shreyamalviya]

So the exploiters are plugins but don't use PluginConfiguration?

[mssalvatore]

PluginConfiguration will likely go away at some point.

[VakarisZ]

Went with Dict, because I ran into issues trying to used OrderedDict type hint. We can make it "ordered" later, we don't need the extra method it provides

[mssalvatore]

Let's try to avoid the word "plugin" in the master. There's really no reason this component needs to be aware of plugins. It receives a config from C&C and orders the puppet to take action. "exploiter_options" would be better.

[mssalvatore]

You could maybe do

Suggested change

	for exploiter_name in interruptible_iter(exploiter_configs, stop):
	for exploiter_name, exploiter_config in interruptible_iter(exploiter_configs.items(), stop):

Then you wouldn't need the lookup on line 143. But this is a minor nit.

[mssalvatore]

Approved, but let's add a comment stating that order is important and a dict preserves order.