Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config schema generation #2785

Closed
14 tasks done
VakarisZ opened this issue Jan 5, 2023 · 0 comments · Fixed by #2813
Closed
14 tasks done

Improve config schema generation #2785

VakarisZ opened this issue Jan 5, 2023 · 0 comments · Fixed by #2813

Comments

@VakarisZ
Copy link
Contributor

VakarisZ commented Jan 5, 2023

Is your feature request related to a problem? Please describe.
Hadoop plugin schema should end up in vulnerability exploiters. This means that we need to refactor the vulnerability exploiters' schema and append plugins to it. In the end, we should have a single VulnerabilityExploiters object in the schema that is composed both of plugins and of hard-coded exploiters.

Notes

First do #2787. These changes will break UI, until #2698 is done, consider merging these changes into a separate branch

Tasks

  • Refactor exploiters in common.agent_configuration.agent_sub_configurations.ExploitationConfiguration from Tuple[PluginConfiguration, ...] into an empty Dict (or similar). (0d) - @VakarisZ
  • Refactor monkey/monkey_island/cc/services/agent_configuration_schema_service.py (probably the code in repository utils) to add the plugin schema to the exploiters' schema. - @VakarisZ
    • Define hard-coded exploiter "plugins" (0d)
      • Define HadoopExploiter property
      • Define Log4ShellExploiter property
      • Define MSSQLExploiter property
      • Define PowerShellExploiter property
      • Define SSHExploiter property
      • Define SMBExploiter property
      • Define WmiExploiter property
      • Define ZerologonExploiter property
    • Modify the service to inject hard-coded "plugins" into the schema (0d)
  • Fix the logic in infection_monkey.master.exploiter to use the new schema (0d) - @VakarisZ
  • Modify BB test configurations (0d) - @VakarisZ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants