Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Island: Change the order of log messages on startup to improve UX #1684

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Island: Change the order of log messages on startup to improve UX #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ Changelog](https://keepachangelog.com/en/1.0.0/).
- "Communicate as Backdoor User" PBA's HTTP requests to request headers only and
include a timeout. #1577
- The setup procedure for custom server_config.json files to be simpler. #1576
- The order and content of Monkey Island's initialization logging to give
clearer instructions to the user and avoid confusion. #1684

### Removed
- The VSFTPD exploiter. #1533
Expand Down
14 changes: 10 additions & 4 deletions monkey/monkey_island/cc/server_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,17 @@ def _start_bootloader_server() -> Thread:


def _log_init_info():
MonkeyDownload.log_executable_hashes()

logger.info("Monkey Island Server is running!")
logger.info(f"version: {get_version()}")

_log_web_interface_access_urls()


def _log_web_interface_access_urls():
web_interface_urls = ", ".join([f"https://{ip}:{ISLAND_PORT}" for ip in local_ip_addresses()])
logger.info(
"Listening on the following URLs: {}".format(
", ".join(["https://{}:{}".format(x, ISLAND_PORT) for x in local_ip_addresses()])
)
"To access the web interface, navigate to one of the the following URLs using your "
f"browser: {web_interface_urls}"
)
MonkeyDownload.log_executable_hashes()