Island: Change the order of log messages on startup to improve UX #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
requested review from
ilija-lazoroski,
VakarisZ and
shreyamalviya
Some users were confused when the Island started up and thought it had frozen. I hope to alleviate this confusion by changing the order of the log messages. If the last message displayed after initialization gives the user instructions on accessing the island, hopefully users will no longer be confused. PR #1684
mssalvatore
force-pushed
the
island-startup-logging-order
branch
from
a16fe88
to
8371a26
Compare
VakarisZ
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two users contacted me (coincidentally on the same day) and were confused when Monkey Island started. They thought it had frozen when the agent binary hashes were printed to the screen. The instructions for accessing the island are buried in the Island's output and it may be difficult for users to find the appropriate messages.
Before
After
By changing the order and content of the log statements, I hope to alleviate this confusion.
PR Checklist
Is the TravisCI build passing?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?