Add deployment type to the build_scripts #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija-lazoroski
requested review from
mssalvatore,
VakarisZ and
shreyamalviya
Codecov Report
@@ Coverage Diff @@
## develop #1467 +/- ##
========================================
Coverage 41.63% 41.63%
========================================
Files 463 463
Lines 13967 13967
========================================
Hits 5815 5815
Misses 8152 8152 Continue to review full report at Codecov.
|
mssalvatore
reviewed
Sep 15, 2021
build_scripts/build_package.sh
Outdated
Comment on lines
79
to
87
| install_common_build_prereqs() { | ||
| sudo apt-get update | ||
| sudo apt-get upgrade -y | ||
|
|
||
| # monkey island prereqs | ||
| sudo apt-get install -y curl libcurl4 openssl git build-essential moreutils | ||
| install_nodejs | ||
| } | ||
|
|
ilija-lazoroski
force-pushed
the
1205/modify-build-scripts-deployment
branch
from
c653f49
to
c4ab6f4
Compare
…ployment string if no deployment argument is passed
VakarisZ
force-pushed
the
1205/modify-build-scripts-deployment
branch
from
bde710c
to
cfff225
Compare
mssalvatore
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1205 .
Add any further explanations here.
PR Checklist
Testing Checklist
Explain Changes
Are the commit messages enough? If not, elaborate.