Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"deployment" field should not be stored in server_config.json #1205

Closed
7 tasks done
mssalvatore opened this issue Jun 3, 2021 · 0 comments · Fixed by #1467
Closed
7 tasks done

"deployment" field should not be stored in server_config.json #1205

mssalvatore opened this issue Jun 3, 2021 · 0 comments · Fixed by #1467
Labels
Code Quality Deficiencies in code quality Complexity: Low Impact: Medium sp/5

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Jun 3, 2021 •
edited
Loading

The deployment field is not a runtime configuration option. It is a way for Guardicore to track which versions of Infection Monkey are being used. (See https://www.guardicore.com/infectionmonkey/docs/faq/#exactly-what-internet-queries-does-the-infection-monkey-perform for details about what information is being collected.) As such, it should not be stored in the same file with user-configurable options, but should be stored in a read-only location.

  • Delete the deployment option from server_config.json. (0d) - @shreyamalviya
  • Extract deployment name into a separate file in monkey_island/cc/deployment.json and make it develop by default. Change the monkey code to use this file as source of truth. (0d) - @shreyamalviya, @ilija-lazoroski
  • Add UTs for reading the monkey_island/cc/deployment.json and fix the tests in monkey/tests/unit_tests/monkey_island/cc/environment/test_environment_config.py. (0d) @ilija-lazoroski, @shreyamalviya
  • Modify build scripts to write out the deployment name into monkey_island/cc/deployment.json. (0d) @ilija-lazoroski
  • Build all of the deployments and make sure the deployment is correct. (0d)
    • Run all deployments
    • Verify that correct IP address and deployment name appears in the lamda (check the confluence)
mssalvatore added a commit that referenced this issue Jun 4, 2021
@mssalvatore
island: Remove server_config.json.develop
318ddac 
Since Monkey Island no longer writes to server_config.json in the source
code directory, and each package will overwrite server_config.json with
its own server config (until we separate the deployment from the config
in issue #1205), we no longer need server_config.json.develop and we
don't need to worry about accidentally committing credentials to git.
mssalvatore added a commit that referenced this issue Jun 4, 2021
@mssalvatore
island: Remove server_config.json.develop
56b9122 
Since Monkey Island no longer writes to server_config.json in the source
code directory, and each package will overwrite server_config.json with
its own server config (until we separate the deployment from the config
in issue #1205), we no longer need server_config.json.develop and we
don't need to worry about accidentally committing credentials to git.
mssalvatore added a commit that referenced this issue Jun 4, 2021
@mssalvatore
island: Remove server_config.json.develop
0cd9709 
Since Monkey Island no longer writes to server_config.json in the source
code directory, and each package will overwrite server_config.json with
its own server config (until we separate the deployment from the config
in issue #1205), we no longer need server_config.json.develop and we
don't need to worry about accidentally committing credentials to git.
@mssalvatore mssalvatore added the Code Quality Deficiencies in code quality label Aug 25, 2021
@shreyamalviya shreyamalviya mentioned this issue Sep 13, 2021
Merged
7 tasks
@ilija-lazoroski ilija-lazoroski mentioned this issue Sep 15, 2021
Merged
7 tasks
@mssalvatore mssalvatore reopened this Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality Deficiencies in code quality Complexity: Low Impact: Medium sp/5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deployment type to the build_scripts guardicore/monkey
1 participant
@mssalvatore