Zoo: Change island to use credentials #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1452 +/- ##
========================================
Coverage 40.36% 40.36%
========================================
Files 465 465
Lines 13908 13908
========================================
Hits 5614 5614
Misses 8294 8294 Continue to review full report at Codecov.
|
VakarisZ
approved these changes
Sep 6, 2021
shreyamalviya
requested changes
Sep 6, 2021
| LOGGER = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class AuthenticationFailedError(Exception): | ||
| pass | ||
|
|
||
|
|
||
| class InvalidRegistrationCredentialsError(Exception): |
There was a problem hiding this comment.
Would simply InvalidCredentialsError make more sense?
| def try_set_island_to_no_password(self): | ||
| requests.patch( # noqa: DUO123 | ||
| self.addr + "api/environment", json={"server_config": "standard"}, verify=False | ||
| def try_set_island_to_credentials(self): |
There was a problem hiding this comment.
This function name doesn't make a lot of sense. How about try_log_in_to_island() or try_island_login()?
| @@ -117,6 +125,5 @@ def delete(self, url): | |||
| self.addr + url, headers=self.get_jwt_header(), verify=False | |||
| ) | |||
|
|
|||
| @_Decorators.refresh_jwt_token | |||
There was a problem hiding this comment.
Why are we removing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #1418 .
Add any further explanations here.
PR Checklist
Testing Checklist
Explain Changes
Are the commit messages enough? If not, elaborate.