Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "insecure access" feature #1418

Closed
4 tasks done
mssalvatore opened this issue Aug 18, 2021 · 2 comments
Closed
4 tasks done

Remove "insecure access" feature #1418

mssalvatore opened this issue Aug 18, 2021 · 2 comments

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Aug 18, 2021

Infection Monkey stores very sensitive information (passwords, NTLM hashes, SSH keys, etc.) that could give someone access to large portions of the network. Further more, Infection Monkey allows you to configure it to run arbitrary scripts or executables on any system it can breach. This means Infection Monkey is a very dangerous tool for someone malicious to be able to access. For this reason, we should not allow users to configure unsecured Monkey Islands.

The "I want anyone to access the island" option should be removed.

image

Tasks

  • Remove StandardEnvironment in the agent and fix unit tests. (0d) - @shreyamalviya
  • Remove "I want anyone to access" in the frontend (button and setNoAuth()). (0d) - @shreyamalviya
  • Fix blackbox tests to use credentials. (0d) @ilija-lazoroski
  • Thorough testing. (0d)
@VakarisZ
Copy link
Contributor

This is useful for us and for test environments, where the island machine is protected via other means. Unless the main goal of this effort is to reduce complexity, I'd suggest a prompt that explains what this option means. This would be cheaper and would make sure that users understand the consequences. Also, we wouldn't need to constantly log in while developing.

@mssalvatore
Copy link
Collaborator Author

Reducing complexity is definitely a motivating factor for this, especially since any complexity in the authentication system can potentially hide security issues. Ideally we should use an off-the-shelf authentication solution, but that's a bigger problem for a different day.

I think we need to look at why our tokens expire so frequently while we're using the system, rather than renewing themselves so the user/developer isn't constantly being kicked out.

During development, we may be able to find a way to disable the authentication that's cleaner than the current mechanism.

mssalvatore added a commit that referenced this issue Oct 8, 2021
Since #1418, credentials are always required, rendering the
_credentials_required property of the Environment class obsolete.
mssalvatore added a commit that referenced this issue Oct 12, 2021
Since #1418, credentials are always required, rendering the
_credentials_required property of the Environment class obsolete.
mssalvatore added a commit that referenced this issue Oct 12, 2021
Since #1418, credentials are always required, rendering the
_credentials_required property of the Environment class obsolete.
mssalvatore added a commit that referenced this issue Oct 13, 2021
Since #1418, credentials are always required, rendering the
_credentials_required property of the Environment class obsolete.
mssalvatore added a commit that referenced this issue Oct 20, 2021
Since #1418, credentials are always required, rendering the
_credentials_required property of the Environment class obsolete.
mssalvatore added a commit that referenced this issue Oct 26, 2021
Since #1418, credentials are always required, rendering the
_credentials_required property of the Environment class obsolete.
mssalvatore added a commit that referenced this issue Oct 28, 2021
Since #1418, credentials are always required, rendering the
_credentials_required property of the Environment class obsolete.
VakarisZ pushed a commit that referenced this issue Jan 14, 2022
Since #1418, credentials are always required, rendering the
_credentials_required property of the Environment class obsolete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants