Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake8 improvements #1078

Merged
merged 12 commits into from
Apr 6, 2021
Merged

Flake8 improvements #1078

merged 12 commits into from
Apr 6, 2021

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented Apr 6, 2021 •
edited
Loading

What does this PR do?

  1. Fail Travis build on any flake8 issue
  2. Resolve a number of flake8 warnings

This PR is in support of #1071

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running blackbox tests

  • If applicable, add screenshots or log transcripts of the feature working

@mssalvatore mssalvatore marked this pull request as ready for review April 6, 2021 01:29
@ghost
Copy link

ghost commented Apr 6, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

shreyamalviya
shreyamalviya reviewed Apr 6, 2021
View reviewed changes
.flake8 Show resolved Hide resolved
@mssalvatore mssalvatore merged commit 47b7467 into develop Apr 6, 2021
@mssalvatore mssalvatore deleted the flake8 branch April 6, 2021 11:15
@cakekoa cakekoa mentioned this pull request May 15, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyamalviya shreyamalviya shreyamalviya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mssalvatore @shreyamalviya