Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve C901 issues #1076

Closed
6 tasks done
mssalvatore opened this issue Apr 5, 2021 · 0 comments
Closed
6 tasks done

Resolve C901 issues #1076

mssalvatore opened this issue Apr 5, 2021 · 0 comments
Assignees
@cakekoa
Labels
Code Quality Deficiencies in code quality Complexity: Medium Impact: Medium sp/5
Milestone
v2.2.0

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Apr 5, 2021 •
edited by ilija-lazoroski
Loading

Flake8 identifies nineteen C901 complexity warnings. Resolve these warnings by refactoring the code and remove C901 from the extend-ignore list in .flake8

image

Tasks

  • Resolve C901 issue in the dropper (0d) @cakekoa
  • Resolve C901 issue in http_client (0d) - @shreyamalviya
  • Resolve C901 issue in tcp_scanner (0d) @ilija-lazoroski
  • Resolve C901 issue in info.py (0d) @ilija-lazoroski
  • Remove C901 from the ignore list in.flake8 configuration file
    • Add ignore for any Zerologon warnings
@mssalvatore mssalvatore added the Code Quality Deficiencies in code quality label Apr 5, 2021
mssalvatore added a commit that referenced this issue Apr 5, 2021
@mssalvatore
ci: add C901 to flake8's extend-ignore list
07afa27 
Issue #1076 has been created to track the task of resolving C901 errors
and removing C901 from the ignore list.
@mssalvatore mssalvatore added this to the v2.2.0 milestone Mar 28, 2023
@cakekoa cakekoa self-assigned this May 11, 2023
ilija-lazoroski added a commit that referenced this issue May 15, 2023
@ilija-lazoroski
Agent: Refactor get_routes to resolve C901
28a440b 
Issue: #1076
PR:
@ilija-lazoroski ilija-lazoroski mentioned this issue May 15, 2023
Merged
10 tasks
ilija-lazoroski added a commit that referenced this issue May 15, 2023
@ilija-lazoroski
Agent: Refactor get_routes to resolve C901
f5717c7 
Issue: #1076
PR: #3334
@ilija-lazoroski ilija-lazoroski mentioned this issue May 15, 2023
Merged
10 tasks
ilija-lazoroski added a commit that referenced this issue May 15, 2023
@ilija-lazoroski
Agent: Refactor _check_tcp_ports to resolve C901
432e0c7 
Issue: #1076
PR: #3335
@shreyamalviya shreyamalviya mentioned this issue May 15, 2023
Merged
10 tasks
mssalvatore pushed a commit that referenced this issue May 15, 2023
@shreyamalviya @mssalvatore
Agent: Extract method _handle_http_error() to reduce CCN
0997669 
Issue #1076
PR #3336
mssalvatore pushed a commit that referenced this issue May 15, 2023
@shreyamalviya @mssalvatore
Agent: Extract method _handle_http_error() to reduce CCN
6513c43 
Issue #1076
PR #3336
ilija-lazoroski added a commit that referenced this issue May 15, 2023
@ilija-lazoroski
Agent: Refactor _check_tcp_ports to resolve C901
559f0a8 
Issue: #1076
PR: #3335
@cakekoa cakekoa mentioned this issue May 15, 2023
Merged
10 tasks
ilija-lazoroski added a commit that referenced this issue May 15, 2023
@ilija-lazoroski
Agent: Refactor get_routes to resolve C901
cd235d9 
Issue: #1076
PR: #3334
ilija-lazoroski added a commit that referenced this issue May 15, 2023
@ilija-lazoroski
Agent: Refactor _check_tcp_ports to resolve C901
930607a 
Issue: #1076
PR: #3335
mssalvatore pushed a commit that referenced this issue May 15, 2023
@ilija-lazoroski @mssalvatore
Agent: Refactor get_routes to resolve C901
4a1b672 
Issue: #1076
PR: #3334
mssalvatore pushed a commit that referenced this issue May 15, 2023
@ilija-lazoroski @mssalvatore
Agent: Refactor get_routes to resolve C901
49da8ce 
Issue: #1076
PR: #3334
mssalvatore added a commit that referenced this issue May 15, 2023
@mssalvatore
Merge branch '1076-dropper' into develop
3d9c03e 
Issue #1076
PR #3337
mssalvatore pushed a commit that referenced this issue May 15, 2023
@ilija-lazoroski @mssalvatore
Agent: Refactor _check_tcp_ports to resolve C901
3675609 
Issue: #1076
PR: #3335
mssalvatore added a commit that referenced this issue May 15, 2023
@mssalvatore
Merge branch '1076-flake8-config' into develop
43b5b4b 
Issue #1076
PR #3338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cakekoa cakekoa

Labels
Code Quality Deficiencies in code quality Complexity: Medium Impact: Medium sp/5
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
3 participants
@cakekoa @ilija-lazoroski @mssalvatore