Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan target hostnames with dashes are not resolved #3231

Closed
1 task
cakekoa opened this issue Apr 17, 2023 — with Slack · 0 comments · Fixed by #3352
Closed
1 task

Scan target hostnames with dashes are not resolved #3231

cakekoa opened this issue Apr 17, 2023 — with Slack · 0 comments · Fixed by #3352
Assignees
@ilija-lazoroski
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Impact: Low Impact: Medium sp/3
Milestone
v2.2.0

Comments

@cakekoa Slack
Copy link
Contributor

cakekoa commented Apr 17, 2023 •
edited by ilija-lazoroski
Loading

If a hostname with dashes is added to the "Scan target list", it will not get resolved, and will not be scanned. This is because it is interpreted as an IP range, two IPs separated by a dash.

Related code:
network_range.py:

  • NetworkRange.get_range_obj() converts a string into a NetworkRange
  • NetworkRange.check_if_range() is where we determine whether or not a string is a range
  • SingleIpRange.string_to_host() is where hostnames are resolved

NetworkRange.check_if_range("hadoop-3") returns True. It should return False

Tasks

  • Fix it (0.5d)
@mssalvatore mssalvatore mentioned this issue Apr 17, 2023
Closed
@mssalvatore mssalvatore added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Impact: Medium Impact: Low labels Apr 17, 2023
@mssalvatore mssalvatore added this to the v2.2.0 milestone Apr 17, 2023
@ilija-lazoroski ilija-lazoroski self-assigned this May 17, 2023
ilija-lazoroski added a commit that referenced this issue May 17, 2023
@ilija-lazoroski
Common: Resolve hostnames with dashes
c0d6379 
Issue: #3231
PR:
@ilija-lazoroski ilija-lazoroski mentioned this issue May 17, 2023
Merged
10 tasks
ilija-lazoroski added a commit that referenced this issue May 17, 2023
@ilija-lazoroski
Common: Resolve scan target hostnames with dashes
b456c8d 
Issue: #3231
PR: #3352
ilija-lazoroski added a commit that referenced this issue May 17, 2023
@ilija-lazoroski
Common: Resolve scan target hostnames with dashes
3e59e67 
Issue: #3231
PR: #3352
ilija-lazoroski added a commit that referenced this issue May 17, 2023
@ilija-lazoroski
Common: Resolve scan target hostnames with dashes
e9364a0 
Issue: #3231
PR: #3352
mssalvatore added a commit that referenced this issue May 17, 2023
@mssalvatore
Merge branch '3231-resolve-hostname-with-dashes' into develop
767e7c3 
Issue #3231
PR #3352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilija-lazoroski ilija-lazoroski

Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Impact: Low Impact: Medium sp/3
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging a pull request may close this issue.

3231 resolve hostname with dashes guardicore/monkey
3 participants
@cakekoa @ilija-lazoroski @mssalvatore