Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid IP values can be submitted in configuration #3225

Closed
shreyamalviya opened this issue Apr 13, 2023 · 1 comment
Closed

Invalid IP values can be submitted in configuration #3225

shreyamalviya opened this issue Apr 13, 2023 · 1 comment
Assignees
@cakekoa
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Medium Impact: Medium

Comments

@shreyamalviya
Copy link
Contributor

Describe the bug

The hostname validation is buggy which is why invalid values can be submitted in the configuration.

To Reproduce

Steps to reproduce the behavior:

  1. Run the Island
  2. Try adding a simple string like "aaaa" in scan target list
  3. See that it gets submitted successfully

Expected behavior

It shouldn't be submitted successfully.

The logic in validate_hostname() needs to be modified. UTs also need to be added for it.
@shreyamalviya shreyamalviya added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Impact: Medium Complexity: Medium labels Apr 13, 2023
@cakekoa cakekoa self-assigned this Apr 13, 2023
@mssalvatore
Copy link
Collaborator

Strings can be valid hostnames. This is acceptable input. However, we have found a small bug. See #3231.

@mssalvatore mssalvatore closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cakekoa cakekoa

Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Medium Impact: Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cakekoa @mssalvatore @shreyamalviya