Better determination of migration rate plans for GW2024 #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrf1
reviewed
Mar 26, 2024
lambda/src/main/scala/pricemigrationengine/migrations/GW2024Migration.scala
Outdated
Show resolved
Hide resolved
lambda/src/main/scala/pricemigrationengine/migrations/GW2024Migration.scala
Outdated
Show resolved
Hide resolved
lambda/src/main/scala/pricemigrationengine/migrations/GW2024Migration.scala
Outdated
Show resolved
Hide resolved
|
Thanks for the point of syntax @kelvin-chappell :) |
tomrf1
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the ongoing series of PRs to show how a migration is implemented using the case of GW2024 as example.
Here we are not adding a new step yet, but making an improvement to the code of the Estimation Step ( #1019 ). A better way to determine the active rate plan. And notably notes on dealing with the fact that Zuora doesn't always provide the
lastChangeTypeattribute of a rate plan.