Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
This is the fourth PR in our series where we are using the GW2024 migration to show how to organise the changes required to build a modern migration.
Here we prepare the Estimation step. For this we do the following
The core of the GW2024 Estimation step is the
GW2024.priceData
function. It's the GW2024 implementation of the more generalAmendmentData.priceData
. The set of functions we added toGW2024Migration
is the smallest set required for this function to return a value.Added tests to cover every function we added in (1.)
Plugged in
StartDates.lastPriceRiseDate
the GW2024 implementation of that function.We opened the Estimation Lambda by removing the lock we had against cohort name "GW2024"