Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GW2024 Part 4: Estimation Step #1019

Merged
merged 3 commits into from
Mar 19, 2024
Merged

GW2024 Part 4: Estimation Step #1019

merged 3 commits into from
Mar 19, 2024

Conversation

shtukas
Copy link
Contributor

@shtukas shtukas commented Mar 19, 2024

Previously:

This is the fourth PR in our series where we are using the GW2024 migration to show how to organise the changes required to build a modern migration.

Here we prepare the Estimation step. For this we do the following

  1. The core of the GW2024 Estimation step is the GW2024.priceData function. It's the GW2024 implementation of the more general AmendmentData.priceData. The set of functions we added to GW2024Migration is the smallest set required for this function to return a value.

  2. Added tests to cover every function we added in (1.)

  3. Plugged in StartDates.lastPriceRiseDate the GW2024 implementation of that function.

  4. We opened the Estimation Lambda by removing the lock we had against cohort name "GW2024"

@shtukas shtukas requested a review from a team as a code owner March 19, 2024 11:18
Copy link
Member

@tomrf1 tomrf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shtukas shtukas merged commit f323f0d into main Mar 19, 2024
1 check passed
@shtukas shtukas deleted the ph-20240319-1050-4 branch March 19, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants