This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
refactor!: Remove any type from storage
#383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxdvl
force-pushed
the
mxdvl/no-any
branch
2 times, most recently
from
05bc766 to
0c9a0a6
Compare
5 tasks
mxdvl
commented
Aug 4, 2022
mxdvl
changed the title
any typesany type from storage
sndrs
approved these changes
Aug 5, 2022
The `any` is very loose, and consumers should make appropriate decision about the data, so `unknown` is more appropriate. The motivation comes from a bug that made its way into production recently.
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Remove
anytypes from thestorageAPI.This is technically a breaking change, as TypeScript consumers will have to update their code to handle the change.
Why?
This caused an issue in Production recently, where the type that became returned as a
numberinstead of a string.