fix(storage): return type of get is unknown

The `any` is very loose, and consumers
should make appropriate decision about
the data, so `unknown` is more appropriate.

The motivation comes from a bug that made its
way into production recently.

src/storage/README.md

@@ -30,7 +30,7 @@ _n.b. the examples below use `storage.local`, but all methods are available for
 
 ## `get(key)`
 
-Returns: `string` | `number` | `boolean` | `null` | `object` | `array`
+Returns: `unknown`
 
 Retrieves an item from storage.
 

src/storage/storage.test.ts

@@ -53,7 +53,6 @@ describe.each([
 		// re-import now we've disabled native storage API
 		const { storage } = await import('./storage');
 		expect(() => storage[name].set('🚫', true)).not.toThrowError();
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-return -- it's correct
 		expect(() => storage[name].get('🚫')).not.toThrowError();
 		expect(() => storage[name].remove('🚫')).not.toThrowError();
 		expect(() => storage[name].getRaw('🚫')).not.toThrowError();
@@ -87,6 +86,11 @@ describe.each([
 		expect(native.getItem('iAmExpired')).toBeNull();
 	});
 
+	it(`return null for a malformed item`, () => {
+		native.setItem('malformed', '[]');
+		expect(implementation.get('malformed')).toBeNull();
+	});
+
 	it(`returns a non-expired item`, () => {
 		implementation.set('iAmNotExpired', 'data', new Date('2040-01-01'));
 		expect(implementation.get('iAmNotExpired')).toBeTruthy();

src/storage/storage.ts

@@ -1,3 +1,6 @@
+import { isObject } from '../isObject/isObject';
+import { isString } from '../isString/isString';
+
 class StorageFactory {
 	#storage: Storage | undefined; // https://mdn.io/Private_class_fields
 
@@ -22,27 +25,19 @@ class StorageFactory {
 		return Boolean(this.#storage);
 	}
 
-	/* eslint-disable
-		@typescript-eslint/no-unsafe-assignment,
-		@typescript-eslint/no-explicit-any,
-		@typescript-eslint/no-unsafe-argument
-		--
-		- we're using the `try` to handle anything bad happening
-		- JSON.parse returns an `any`, we really are with an `any`
-	*/
 	/**
 	 * Retrieve an item from storage.
 	 *
 	 * @param key - the name of the item
 	 */
-	get(key: string): any {
+	get(key: string): unknown {
 		try {
-			const { value, expires } = JSON.parse(
-				this.#storage?.getItem(key) ?? '',
-			);
+			const data: unknown = JSON.parse(this.#storage?.getItem(key) ?? '');
+			if (!isObject(data)) return null;
+			const { value, expires } = data;
 
 			// is this item has passed its sell-by-date, remove it
-			if (expires && new Date() > new Date(expires)) {
+			if (isString(expires) && new Date() > new Date(expires)) {
 				this.remove(key);
 				return null;
 			}
@@ -52,11 +47,6 @@ class StorageFactory {
 			return null;
 		}
 	}
-	/* eslint-enable
-		@typescript-eslint/no-unsafe-assignment,
-		@typescript-eslint/no-explicit-any,
-		@typescript-eslint/no-unsafe-argument
-	*/
 
 	/**
 	 * Save a value to storage.