feat: Surface Lighthouse results #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored by: @mxdvl co-authored by: @bryophyta
co-author: @mxdvl co-author: @bryophyta
Co-authored-by: Joshua <[email protected]> Co-authored-by: Pete Faulconbridge <[email protected]>
Actually run the deno script Co-authored-by: Joshua <[email protected]> Co-authored-by: Pete Faulconbridge <[email protected]>
|
Size Change: -17.4 kB (-1%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
Co-authored-by: Pete Faulconbridge <[email protected]> Co-authored-by: Joshua <[email protected]>
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
mxdvl
requested review from
a team,
JamieB-gu,
marsavar and
iainjchambers-guardian
as code owners
|
if we’re all happy with this I will squash & merge, because there’s lots of WIP commits in there. |
that's fine by me 👍 |
bryophyta
reviewed
Apr 29, 2022
also update the location of the `includePassedAssertions` setting to be inside the lighthouserc.js config file
jlieb10
reviewed
May 3, 2022
jlieb10
reviewed
May 3, 2022
Yes I sometimes do a WIP after pairing if a task hasn't reached its endpoint but I need to sign off, so the branch can be pulled by whoever else is working on it. Big fan of squashing when I merge. |
jlieb10
reviewed
May 3, 2022
| const dir = "dotcom-rendering/.lighthouseci"; | ||
|
|
||
| const links: Record<string, string> = JSON.parse( | ||
| Deno.readTextFileSync(`${dir}/links.json`) |
jlieb10
reviewed
May 3, 2022
AshCorr
approved these changes
May 3, 2022
| const getStatus = ( | ||
| passed: boolean, | ||
| level: AssertionResult["level"] | ||
| ): "✅" | "⚠️" | "❌" => { |
There was a problem hiding this comment.
Theres something interesting about a function that has an "emoji" return type, love it!
also remove console logs
This was referenced May 3, 2022
|
A bit cheeky, usually this would be for others’s PRs, but I’ll nominate this as a hidden gem 💎 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Surface Lighthouse results in all PRs. On merge to
main, update the comment on #4584 to reflect the latest Lighthouse scores.The script updating the comment is powered by Deno and Github’s official
@octokit’s libraries, as well as types from thelhci/clilibrary.Why?
Closes #4584
Screenshots