Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface Github Lighthouse numbers on PRs #4584

Closed
2 of 3 tasks
jlieb10 opened this issue Apr 11, 2022 · 8 comments · Fixed by #4773
Closed
2 of 3 tasks

Surface Github Lighthouse numbers on PRs #4584

jlieb10 opened this issue Apr 11, 2022 · 8 comments · Fixed by #4773
Assignees
@bryophyta
Labels
📊 Data

Comments

@jlieb10
Copy link
Contributor

jlieb10 commented Apr 11, 2022 •
edited by mxdvl
Loading

  • Surface budgets on PRs. These are already breaking, but we aren't reporting them
  • Surface change from main on PRs this issue.
  • Choose the pages we should be reporting on
    • We should be testing across as many features as we can
    • We should have a representative list of general content that we produce
    • We should make sure we don't negatively impact build speed too much
@jamesgorrie jamesgorrie mentioned this issue Apr 11, 2022
Merged
@bryophyta
Copy link
Contributor

Some notes from initial research:

@mxdvl mxdvl assigned mxdvl and bryophyta and unassigned mxdvl Apr 27, 2022
@jlieb10 jlieb10 moved this from Todo to In Progress in WebX team (do not use) Apr 27, 2022
@jlieb10
Copy link
Contributor Author

jlieb10 commented Apr 27, 2022

Todo:

  • create a comment if it doesn’t (instead of re-writing the PR)
  • find comment id and update if it exists

@mxdvl mxdvl mentioned this issue Apr 28, 2022
Merged
@mxdvl
Copy link
Contributor

mxdvl commented Apr 29, 2022 •
edited by github-actions bot
Loading

⚡️ Lighthouse report for the changes in this PR

Lighthouse tested 2 URLs

⚠️ Budget exceeded for 3 of 12 audits.

Report for Article

tested url https://www.theguardian.com/commentisfree/2020/feb/08/hungary-now-for-the-new-right-what-venezuela-once-was-for-the-left

Category Status Expected Actual
First Contentful Paint ✅ 1500 1205
Largest Contentful Paint ✅ 3000 1285
Time to Interactive ✅ 3500 2916
Cumulative Layout Shift ⚠️ 0.002 0.015523
Total Blocking Time ⚠️ 219 252
accessibility ✅ 0.98 1.000000

Report for Front

tested url https://www.theguardian.com/uk

Category Status Expected Actual
First Contentful Paint ✅ 1500 1402
Largest Contentful Paint ✅ 3000 1486
Time to Interactive ✅ 3500 2230
Cumulative Layout Shift ⚠️ 0.002 0.011354
Total Blocking Time ✅ 716 411
accessibility ✅ 0.98 0.980000

Repository owner moved this from In Progress to Done in WebX team (do not use) May 3, 2022
mxdvl added a commit that referenced this issue May 3, 2022
@mxdvl @jlieb10 @bryophyta
feat(lighthouse): surface scores on every PR
61d4726 
Adding new deno script that surface lighthouse results
on every PR. On pushes to main, update issue #4584:
#4584

- Add TS types for the Github API & Lighthouse
- Run workflow on pull_request "opened" & "synchronize"
- `includePassedAssertions` to get passed checks

Co-authored-by: Joshua <[email protected]>
Co-authored-by: Pete Faulconbridge <[email protected]>
@mxdvl mxdvl mentioned this issue May 3, 2022
Merged
@mxdvl mxdvl pinned this issue May 4, 2022
@jlieb10 jlieb10 unpinned this issue May 5, 2022
@mxdvl mxdvl mentioned this issue May 20, 2022
Merged
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

<-- url: http://localhost:9000/Article?url=https://www.theguardian.com/commentisfree/2020/feb/08/hungary-now-for-the-new-right-what-venezuela-once-was-for-the-left#noads -->

⚡️ Lighthouse report for the changes in this PR

Report for Article

⚠️ Budget exceeded for 1 of 5 audits.

tested url https://www.theguardian.com/commentisfree/2020/feb/08/hungary-now-for-the-new-right-what-venezuela-once-was-for-the-left#noads

Category Status Expected Actual
First Contentful Paint ✅ 1500 1177
Largest Contentful Paint ✅ 3000 1707
Time to Interactive ✅ 3500 2346
Cumulative Layout Shift ⚠️ 0.002 0.005821
accessibility ✅ 0.97 0.980000

@guardian guardian deleted a comment from github-actions bot Oct 26, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR

Report for /Article

⚠️ Budget exceeded for 2 of 6 audits.

tested url https://www.theguardian.com/commentisfree/2020/feb/08/hungary-now-for-the-new-right-what-venezuela-once-was-for-the-left

Category Status Expected Actual
First Contentful Paint ✅ 1500 1257
Largest Contentful Paint ✅ 3000 2424
Time to Interactive ✅ 3500 2839
Cumulative Layout Shift ⚠️ 0.002 0.015523
Total Blocking Time ⚠️ 219 255
accessibility ✅ 0.98 0.980000

@github-actions
Copy link

github-actions bot commented Feb 9, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR

Report for /Front

⚠️ Budget exceeded for 1 of 6 audits.

tested url https://www.theguardian.com/uk

Category Status Expected Actual
First Contentful Paint ✅ 1500 1354
Largest Contentful Paint ✅ 3000 2178
Time to Interactive ✅ 3500 2810
Cumulative Layout Shift ⚠️ 0.002 0.011200
Total Blocking Time ✅ 716 312
accessibility ✅ 0.98 0.980000

@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR

Report for Article

⚠️ Budget exceeded for 2 of 6 audits.

tested url http://localhost:9000/Article/https://www.theguardian.com/commentisfree/2020/feb/08/hungary-now-for-the-new-right-what-venezuela-once-was-for-the-left#noads

Category Status Expected Actual
First Contentful Paint ✅ 1500 1206
Largest Contentful Paint ✅ 3000 1325
Time to Interactive ✅ 3500 2904
Cumulative Layout Shift ⚠️ 0.002 0.011139
Total Blocking Time ⚠️ 219 321
accessibility ✅ 0.98 0.980000

@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR

Report for Front

⚠️ Budget exceeded for 1 of 6 audits.

tested url http://localhost:9000/Front/https://www.theguardian.com/uk

Category Status Expected Actual
First Contentful Paint ✅ 1500 1411
Largest Contentful Paint ✅ 3000 2708
Time to Interactive ✅ 3500 3037
Cumulative Layout Shift ⚠️ 0.002 0.018324
Total Blocking Time ✅ 716 628
accessibility ✅ 0.98 0.980000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryophyta bryophyta

Labels
📊 Data
Projects
No open projects
WebX team (do not use)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Surface Lighthouse results guardian/dotcom-rendering
3 participants
@mxdvl @jlieb10 @bryophyta