Lift comment state into discussion #10299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +471 B (0%) Total Size: 749 kB
ℹ️ View Unchanged
|
abeddow91
commented
Jan 23, 2024
|
Hello 👋! When you're ready to run Chromatic, please apply the |
abeddow91
changed the title
mxdvl
reviewed
Jan 23, 2024
| const [commentPageSize, setCommentPageSize] = useState<25 | 50 | 100>(); | ||
| const [commentOrderBy, setCommentOrderBy] = useState< | ||
| 'newest' | 'oldest' | 'recommendations' | ||
| >(); | ||
| const [isExpanded, setIsExpanded] = useState<boolean>(false); | ||
| const [commentCount, setCommentCount] = useState(0); |
There was a problem hiding this comment.
We have useCommentCount for this specific purpose
There was a problem hiding this comment.
Ah, great, thanks Max! I didn't know that existed. I'll update the code to use that 👍
There was a problem hiding this comment.
I’ve actually discovered that commentCount and topLevelCommentCount cannot be conflated… the former relates to the number of comments, the latter to the number of threads!
Fix in #10477
mxdvl
reviewed
Jan 23, 2024
Its a good question! I'm unsure how useful it is as a hook really. It returns |
abeddow91
force-pushed
the
ab/refactor-comment-state
branch
2 times, most recently
from
b6dd805 to
855126e
Compare
abeddow91
force-pushed
the
ab/refactor-comment-state
branch
from
6f04d1b to
5ed59fc
Compare
|
Seen on PROD (merged by @abeddow91 9 minutes and 32 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Lifts up comment state into the discussion component and out of comments. This means we only make one API call, and don't duplicate state.
It also removes the useDiscussion hook and implements the useCommentCount hook in discussion and discussion meta.
It also updates the comment stories to use manual fixture data.
Why?
We want discussion to have the source of truth for shared state. This makes the discussion app easier to read and reason about.
This is part of