Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No duplicated state in Discussion #10229

Closed
Tracked by #10056
abeddow91 opened this issue Jan 16, 2024 · 1 comment
Closed
Tracked by #10056

No duplicated state in Discussion #10229

abeddow91 opened this issue Jan 16, 2024 · 1 comment
Assignees

Comments

@abeddow91
Copy link
Contributor

abeddow91 commented Jan 16, 2024

Lift all duplicated state and callbacks from Discussion:

const [commentPage, setCommentPage] = useState<number>();
const [commentPageSize, setCommentPageSize] = useState<25 | 50 | 100>();
const [commentOrderBy, setCommentOrderBy] = useState<
'newest' | 'oldest' | 'recommendations'
>();
const [isExpanded, setIsExpanded] = useState<boolean>(false);
const [hashCommentId, setHashCommentId] = useState<number | undefined>(
commentIdFromUrl(),
);

@abeddow91 abeddow91 self-assigned this Jan 16, 2024
@mxdvl mxdvl added this to the DCR for Apps milestone Jan 16, 2024
@mxdvl mxdvl added this to WebX Team Jan 16, 2024
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Jan 16, 2024
@mxdvl mxdvl moved this from Triage to In Progress in WebX Team Jan 16, 2024
@mxdvl mxdvl changed the title Discussion No duplicated state in Discussion Jan 16, 2024
@abeddow91 abeddow91 moved this from In Progress to Review in WebX Team Jan 24, 2024
@abeddow91 abeddow91 moved this from Review to Done in WebX Team Jan 25, 2024
@abeddow91
Copy link
Contributor Author

#10299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants