Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Descendants of DiscussionContainer are controlled components #10056

Closed
8 tasks done
Tracked by #8745
mxdvl opened this issue Jan 4, 2024 · 0 comments
Closed
8 tasks done
Tracked by #8745

[Epic] Descendants of DiscussionContainer are controlled components #10056

mxdvl opened this issue Jan 4, 2024 · 0 comments
Labels

Comments

@mxdvl
Copy link
Contributor

mxdvl commented Jan 4, 2024

Make all the descendants of DiscussionContainer controlled components – see React Docs Deep Dive.

flowchart TB
    %% DiscussionContainer.importable -.-> Placeholder
    DiscussionContainer.importable --> DiscussionWhenSignedIn & Discussion
    DiscussionWhenSignedIn --> Discussion
    Discussion --> SignedInAs & Comments
    %% Discussion -.-> Hide & Button & SvgPlus
    Comments --> TopPicks & Filters & Pagination & CommentContainer & CommentForm & LoadingComments
    CommentContainer --> Comment & CommentReplyPreview & CommentForm
    CommentForm --> FirstCommentWelcome & Preview
Loading

In order to make sense of this, we need to unify all duplicated state from components, and pass callbacks to handle events.

@mxdvl mxdvl added this to WebX Team Jan 4, 2024
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Jan 4, 2024
@mxdvl mxdvl added this to the Discussion for Apps milestone Jan 4, 2024
@mxdvl mxdvl changed the title Make all the descendants of DiscussionContainer controlled components Descendants of DiscussionContainer are controlled components Jan 4, 2024
@mxdvl mxdvl modified the milestones: Discussion for Apps, DCR for Apps Jan 5, 2024
@alinaboghiu alinaboghiu moved this from Triage to Backlog in WebX Team Jan 12, 2024
@mxdvl mxdvl moved this from Backlog to This Sprint in WebX Team Jan 16, 2024
@mxdvl mxdvl moved this from This Sprint to In Progress in WebX Team Jan 16, 2024
@shesah shesah changed the title Descendants of DiscussionContainer are controlled components [Epic] Descendants of DiscussionContainer are controlled components Jan 25, 2024
@shesah shesah closed this as completed Feb 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in WebX Team Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants