Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support darkmode - Callouts 💬 #9277

Closed
Tracked by #9110
mxdvl opened this issue Oct 23, 2023 · 0 comments · Fixed by #9663
Closed
Tracked by #9110

Support darkmode - Callouts 💬 #9277

mxdvl opened this issue Oct 23, 2023 · 0 comments · Fixed by #9663
Assignees
@mxdvl
Milestone
DCAR Migration

Comments

@mxdvl
Copy link
Contributor

mxdvl commented Oct 23, 2023 •
edited
Loading

We need to introduce a pattern for handling themes for Source kitchen components:
@mxdvl mxdvl mentioned this issue Oct 23, 2023
Closed
@mxdvl mxdvl self-assigned this Oct 23, 2023
@mxdvl mxdvl changed the title Support darkmode - Callouts Support darkmode - Callouts 💬 Oct 23, 2023
This was referenced Nov 27, 2023
Merged
Merged
Merged
@DanielCliftonGuardian DanielCliftonGuardian added this to the DCR for Apps milestone Nov 30, 2023
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Nov 30, 2023
@DanielCliftonGuardian DanielCliftonGuardian moved this from Triage to In progress in WebX Team Nov 30, 2023
@mxdvl mxdvl mentioned this issue Nov 30, 2023
Merged
mxdvl added a commit to guardian/csnx that referenced this issue Nov 30, 2023
@mxdvl
Support Tabs theming with pure CSS (#964)
5b82282 
## What are you changing?

- Refactor `Tabs` so it receives an optional `theme` object which is
used to define relevant custom properties which drive the colour of the
component
- Remove CSS Overrides as we enable consumers to override every single
colour
- Add stories to demonstrate usage
- Refactors `Tabs` with some destructuring, but this can be kept to a
different PR 0a75669

## Why?

- This enables us to use Callouts with dark mode in dotcom-rendering:
guardian/dotcom-rendering#9277
- Proposal for an answer to:
guardian/dotcom-rendering#9333
@github-project-automation github-project-automation bot moved this from In progress to Done in WebX Team Dec 4, 2023
@oliverabrahams oliverabrahams mentioned this issue Jan 17, 2024
Open
@oliverabrahams oliverabrahams mentioned this issue Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxdvl mxdvl

Labels
None yet
Projects
WebX Team
Archived in project
Milestone
DCAR Migration
Development

Successfully merging a pull request may close this issue.

Support dark mode for Callouts 💬 guardian/dotcom-rendering
2 participants
@mxdvl @DanielCliftonGuardian