Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ExpandingWrapper theming with pure CSS #963

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Nov 27, 2023

What are you changing?

  • Refactor ExpandingWrapper so it receives an optional theme object which is used to define relevant custom properties which drive the colour of the component
  • Remove CSS Overrides as we enable consumers to override every single colour
  • Add stories to demonstrate usage

Why?

@mxdvl mxdvl requested review from a team as code owners November 27, 2023 16:14
Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: ac2e856

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/source-react-components-development-kitchen Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Nov 27, 2023
Copy link
Contributor

@sophie-macmillan sophie-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌔

This enables us to use Callouts with dark mode
in dotcom-rendering
@mxdvl mxdvl force-pushed the mxdvl/expanding-wrapper-dark-mode branch from 050e2da to ac2e856 Compare November 27, 2023 18:16
@mxdvl mxdvl requested a review from a team November 30, 2023 10:43
@mxdvl mxdvl added the run_chromatic Runs chromatic when label is applied label Nov 30, 2023
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxdvl mxdvl merged commit 61afb21 into main Nov 30, 2023
25 checks passed
@mxdvl mxdvl deleted the mxdvl/expanding-wrapper-dark-mode branch November 30, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants