Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for deterministic MDS coordinates #314

Open
revinici opened this issue Nov 15, 2024 · 1 comment
Open

Allow for deterministic MDS coordinates #314

revinici opened this issue Nov 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@revinici
Copy link

I noticed that the MDS coordinates are not the same across panaroo-qc runs when using the same inputs. A random_state can be specified when calling the sklearn.manifold.MDS method here. I believe that should make the MDS coordinates file deterministic for testing purposes. I suggest giving the user the option to specify an integer for the random_state. The mash_dist.txt report does appear to be deterministic, however.

@gtonkinhill gtonkinhill self-assigned this Dec 4, 2024
@gtonkinhill gtonkinhill added the enhancement New feature or request label Dec 4, 2024
@gtonkinhill
Copy link
Owner

Thanks for flagging this. I will look at adding this option in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants