after completing all work related to the AWS SDK v2 resource migration (#770), we should remove any remaining v1 calls. #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakeful
force-pushed
the
moving-away-from-aws-sdk-v1
branch
from
8c6b447 to
99f9975
Compare
|
Hi @wakeful, let me know when it's ready for final review. Thanks for all the contribution! |
wakeful
force-pushed
the
moving-away-from-aws-sdk-v1
branch
from
99f9975 to
c3270dc
Compare
|
FYI @james03160927 The last thing I want to add is a test for the |
Closed
wakeful
force-pushed
the
moving-away-from-aws-sdk-v1
branch
from
494fddc to
a02b833
Compare
|
hey @james03160927 This is now ready for review. I have tried to create logical commits for this change. |
james03160927
previously approved these changes
Dec 21, 2024
gruntwork-io#770), we should remove any remaining v1 calls.
wakeful
force-pushed
the
moving-away-from-aws-sdk-v1
branch
from
a02b833 to
c334187
Compare
wakeful
force-pushed
the
moving-away-from-aws-sdk-v1
branch
from
c334187 to
d7e0c23
Compare
sorted! |
wakeful
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #770 - after completing all work related to the AWS SDK v2 resource migration (#770), we should remove any remaining v1 calls.
We are almost done with the v2 migration. This WIP branch uses only AWS SDK v2 for communication with AWS APIs.
This should be the final MR required to completely remove v1 from the codebase.
TODOs
merge the v2 versions of EC2 and Redshiftutilpackageawserrpackagev2_migration_report)Read the Gruntwork contribution guidelines.
nuke_sandboxandnuke_phxdevopsjobs in.circleci/config.ymlhave been updated with appropriate exclusions (either directly in the job or via the.circleci/nuke_config.ymlfile) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.Release Notes (draft)
Removed AWS SDKv1
Migration Guide
n/a