rm aws sdk v2 migration report

gruntwork-io · Dec 17, 2024 · c3270dc · c3270dc
1 parent 7028989
commit c3270dc
Show file tree

Hide file tree

Showing 9 changed files with 4 additions and 215 deletions.
diff --git a/.gitignore b/.gitignore
@@ -3,4 +3,4 @@ vendor
 .vscode
 cloud-nuke
 config.yaml
-.envrc
+.envrc
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -7,7 +7,7 @@ repos:
   - id: end-of-file-fixer
   - id: check-added-large-files
 - repo: https://github.com/gruntwork-io/pre-commit
-  rev: v0.1.24
+  rev: v0.1.25
   hooks:
     - id: shellcheck
     - id: gofmt
diff --git a/README.md b/README.md
@@ -786,9 +786,6 @@ All other resources that get created within VPCs must be cleaned up prior to run
 
 Happy Nuking!!!
 
-## AWS SDKv2 migration
-We are in progress of migrating towards stable AWS SDKv2, progress can be checked here [migration status](./v2_migration_report/output.md).
-
 ## Credentials
 
 ### AWS

diff --git a/aws/resources/base_resource.go b/aws/resources/base_resource.go
@@ -109,5 +109,5 @@ func (br *BaseAwsResource) IsNukable(identifier string) (bool, error) {
 }
 
 func (br *BaseAwsResource) IsUsingV2() bool {
-	return false
+	return true
 }
diff --git a/aws/v2_migration_report.go b/aws/v2_migration_report.go
diff --git a/config/examples/complete.yaml b/config/examples/complete.yaml
@@ -1795,4 +1795,3 @@ VPCLatticeTargetGroup:
     tag: test
   timeout: 1h
   protect_until_expire: true
-
diff --git a/config/examples/simple.yaml b/config/examples/simple.yaml
@@ -5,4 +5,4 @@ s3:
     - bucket.*
   exclude:
     names_regex:
-    - bucket-.*
+    - bucket-.*
diff --git a/v2_migration_report/main.go b/v2_migration_report/main.go
diff --git a/v2_migration_report/output.md b/v2_migration_report/output.md
-Original file line number
+Diff line change
@@ Expand Up / @@ -3,4 +3,4 @@ vendor @@
     .vscode
     cloud-nuke
     config.yaml
-    .envrc
+    .envrc
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1795,4 +1795,3 @@ VPCLatticeTargetGroup:
		tag: test
		timeout: 1h
		protect_until_expire: true