Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws v2 sdk to support newer resources (#745) #746

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Jul 15, 2024

Description

add support for Managed Prometheus and AWS SDK v2 #745

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

add support for Managed Prometheus & start using AWS SDK v2

@wakeful wakeful requested review from arsci and denis256 as code owners July 15, 2024 14:16
@wakeful wakeful changed the title add aws v2 sdk to support newer resources (#745) [wip] add aws v2 sdk to support newer resources (#745) Jul 15, 2024
@james03160927
Copy link
Contributor

Hi @wakeful, do you plan to make continuous progress on this PR?

@wakeful
Copy link
Contributor Author

wakeful commented Aug 8, 2024

hey @james03160927

Initially, I marked this PR as WIP to start a discussion on the new version of the SDK. If my approach to introducing SDK V2 is agreeable, I will resolve the conflicts and add tests. The main logic remains unchanged.

You should receive an updated PR before the end of this week.

@james03160927 james03160927 self-assigned this Aug 8, 2024
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approach LGTM.
Let's ensure to add tests for managed_prometheus file as well.

@wakeful wakeful force-pushed the feature/add-support-for-amazon-mng-promethus branch from f11a027 to 0b3fc2a Compare August 21, 2024 07:11
@wakeful
Copy link
Contributor Author

wakeful commented Aug 21, 2024

hey @james03160927

Sorry for the late reply!
I finally found some time to add the missing tests.

@wakeful wakeful changed the title [wip] add aws v2 sdk to support newer resources (#745) add aws v2 sdk to support newer resources (#745) Aug 21, 2024
@wakeful wakeful requested a review from james03160927 August 21, 2024 07:15
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit 0c6e8ba into gruntwork-io:master Aug 26, 2024
2 checks passed
@wakeful wakeful deleted the feature/add-support-for-amazon-mng-promethus branch September 25, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants