You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cloud-nuke is currently using an outdated version of the Go SDK. AWS SDK v1 has been officially deprecated. More information here.
what's expected
We should consider and plan an upgrade path to SDK v2.
my approach
Recently, I aimed to add support for Managed Prometheus. However, this resource is only supported in SDK v2. To minimise the impact of the change set, I decided to extend the AwsResource interface with two new methods.
with above in place I was able to extend the initRegisteredResources to configure SDK v2 client using the existing Session.
this allowed me to implement a new resource from SDK v2.
Question for Maintainers
What are your thoughts on adding support for SDK v2? I would appreciate your feedback on my proposed solution and welcome any comments! PR related to this change.
The text was updated successfully, but these errors were encountered:
wakeful
added a commit
to wakeful/cloud-nuke
that referenced
this issue
Jul 15, 2024
the issue
cloud-nuke is currently using an outdated version of the Go SDK. AWS SDK v1 has been officially deprecated. More information here.
what's expected
We should consider and plan an upgrade path to SDK v2.
my approach
Recently, I aimed to add support for Managed Prometheus. However, this resource is only supported in SDK v2. To minimise the impact of the change set, I decided to extend the
AwsResource
interface with two new methods.the
BaseAwsResource
was also extend to define a default behaviourwith above in place I was able to extend the
initRegisteredResources
to configure SDK v2 client using the existingSession
.this allowed me to implement a new resource from SDK v2.
Question for Maintainers
What are your thoughts on adding support for SDK v2? I would appreciate your feedback on my proposed solution and welcome any comments! PR related to this change.
The text was updated successfully, but these errors were encountered: