Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A58 update: Prefer application_utilization to cpu_utilization #373

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

yousukseung
Copy link
Contributor

No description provided.

@yousukseung yousukseung force-pushed the a58-app-util-update branch from fa63bb9 to 366bfda Compare June 5, 2023 11:29
@yousukseung yousukseung marked this pull request as ready for review June 5, 2023 12:32
@dfawley
Copy link
Member

dfawley commented Jun 5, 2023

"Instead of"? Don't we want to prefer application_utilization and then fall back to cpu_utilization so that there is some kind of migration strategy? OK, it seems there's one sentence in there that explains this, but maybe it should be more prominent and part of the pseudo-code?

@markdroth markdroth changed the title A58 update: Use application_utilization instead of cpu_utilization A58 update: Prefer application_utilization to cpu_utilization Jun 5, 2023
A58-client-side-weighted-round-robin-lb-policy.md Outdated Show resolved Hide resolved
A58-client-side-weighted-round-robin-lb-policy.md Outdated Show resolved Hide resolved
A58-client-side-weighted-round-robin-lb-policy.md Outdated Show resolved Hide resolved
A58-client-side-weighted-round-robin-lb-policy.md Outdated Show resolved Hide resolved
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait until #374 is merged before merging this.

@markdroth markdroth merged commit 0ba0c19 into grpc:master Jun 7, 2023
ejona86 pushed a commit to grpc/grpc-java that referenced this pull request Jun 8, 2023
…utilization if unset in WRR (#10256)

Implements updates to [A51][] and [A58][].

Imported cncf/xds using import.sh script.

A51: grpc/proposal#374
A58: grpc/proposal#373
danielzhaotongliu added a commit to danielzhaotongliu/grpc-java that referenced this pull request Jun 8, 2023
…utilization if unset in WRR (grpc#10256)

Implements updates to [A51][] and [A58][].

Imported cncf/xds using import.sh script.

A51: grpc/proposal#374
A58: grpc/proposal#373
ejona86 pushed a commit to grpc/grpc-java that referenced this pull request Jun 9, 2023
…utilization if unset in WRR (#10256)

Implements updates to [A51][] and [A58][].

Imported cncf/xds using import.sh script.

A51: grpc/proposal#374
A58: grpc/proposal#373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants