Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services, xds, orca: use application_utilization and fallback to cpu_utilization if unset in WRR, import cncf/xds #10256

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

danielzhaotongliu
Copy link
Contributor

@danielzhaotongliu danielzhaotongliu commented Jun 7, 2023

  • Import cncf/xds: original cl/538546518
  • Add new APIs to CallMetricRecorder and MetricRecorder for application_utilization
  • Use application_utilization and fallback to cpu_utilization if unset for client-side WRR

@danielzhaotongliu danielzhaotongliu marked this pull request as draft June 8, 2023 16:44
@danielzhaotongliu danielzhaotongliu changed the title xds: import cncf/xds services, xds, orca: use application_utilization and fallback to cpu_utilization if unset in WRR, import cncf/xds Jun 8, 2023
@danielzhaotongliu danielzhaotongliu marked this pull request as ready for review June 8, 2023 18:26
strip_prefix = "xds-32f1caf87195bf3390061c29f18987e51ca56a88",
sha256 = "fcd0b50c013452fda9c5e28c131c287b655ebb361271a76ad3bffc08b3ecd82e",
strip_prefix = "xds-e9ce68804cb4e64cab5a52e3c8baf840d4ff87b7",
sha256 = "0d33b83f8c6368954e72e7785539f0d272a8aba2f6e2e336ed15fd1514bc9899",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: how I got this sha256 value is by running a wget https://github.com/cncf/xds/archive/e9ce68804cb4e64cab5a52e3c8baf840d4ff87b7.tar.gz, then followed by sha256sum e9ce68804cb4e64cab5a52e3c8baf840d4ff87b7.tar.gz

@danielzhaotongliu
Copy link
Contributor Author

PTAL @ejona86. Thanks
I cannot seem to request reviewer in the PR (since I am not a maintainer)
cc @yousukseung

@ejona86 ejona86 self-requested a review June 8, 2023 18:45
@ejona86 ejona86 added TODO:backport PR needs to be backported. Removed after backport complete kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Jun 8, 2023
@grpc-kokoro grpc-kokoro removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Jun 8, 2023
@ejona86 ejona86 merged commit 1daf0ff into grpc:master Jun 8, 2023
danielzhaotongliu added a commit to danielzhaotongliu/grpc-java that referenced this pull request Jun 8, 2023
…utilization if unset in WRR (grpc#10256)

Implements updates to [A51][] and [A58][].

Imported cncf/xds using import.sh script.

A51: grpc/proposal#374
A58: grpc/proposal#373
ejona86 pushed a commit that referenced this pull request Jun 9, 2023
…utilization if unset in WRR (#10256)

Implements updates to [A51][] and [A58][].

Imported cncf/xds using import.sh script.

A51: grpc/proposal#374
A58: grpc/proposal#373
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label Jun 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants