Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix for ipv6 link local with scope (#9326)" (1.48.x backport) #9376

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jul 14, 2022

This reverts commit c1abc7f. It
produced compilation issues inside Google. I strongly suspect it isn't
this commit or gRPC's fault, but it prevents further testing until it is
resolved.

CC @jader-eero

Backport of #9375

This reverts commit c1abc7f. It
produced compilation issues inside Google. I strongly suspect it isn't
this commit or gRPC's fault, but it prevents further testing until it is
resolved.
@ejona86 ejona86 requested a review from sergiitk July 14, 2022 18:46
@ejona86 ejona86 merged commit 826a7c9 into grpc:v1.48.x Jul 15, 2022
@ejona86 ejona86 deleted the backport-revert-ipv6-scope-1.48 branch July 15, 2022 15:33
@jader-eero
Copy link
Contributor

@ejona86 was the issue related to this? If no, when the code will be put back for the 1.48.X?

@ejona86
Copy link
Member Author

ejona86 commented Jul 25, 2022

The issue was that HostAndPort and InetAddresses couldn't be found in a very specific compilation environment. That still needs to be resolved.

@jader-eero
Copy link
Contributor

@ejona86 Thank you for sharing, do you think using the bytes constructor, the first solution, is an option? while the HostAndPort and InetAddresses are not fix.

@jader-eero
Copy link
Contributor

@ejona86 Do you have any update on this? I'd like to stop using a fork version.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants